brijrajk commented on PR #57161: URL: https://github.com/apache/spark/pull/57161#issuecomment-4947839053
Thanks @anuragmantri for the detailed review and for pointing to the UPDATE PR for reference! I've added the options-aware APIs you requested and wired them through all three non-row-level DELETE paths: **New APIs:** - `SupportsDeleteV2.deleteWhere(Predicate[], CaseInsensitiveStringMap)` — back-compatible default ignores options - `SupportsDeleteV2.truncateTable(CaseInsensitiveStringMap)` — delegates to `deleteWhere(AlwaysTrue, options)` - `TruncatableTable.truncateTable(CaseInsensitiveStringMap)` — back-compatible default **Wiring:** - `DeleteFromTableWithFilters` now carries `options` - `OptimizeMetadataOnlyDeleteFromTable` propagates `relation.options` when producing `DeleteFromTableWithFilters` - `DeleteFromTableExec` and `TruncateTableExec` each have an `options` parameter and call the new APIs - `DataSourceV2Strategy` threads `r.options` through all three delete planning paths **Tests:** Four new cases in `DeleteFromTableSuiteBase` verify options reach the row-level operation, metadata-only `deleteWhere`, and delete-all paths respectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
