bojana-db commented on PR #57125: URL: https://github.com/apache/spark/pull/57125#issuecomment-4956237069
> Implementation LGTM. I'm wondering if rejecting `$` is the right idea from an API PoV - maybe a user could want to replace the whole variant in some rows but only replace nested fields in other rows since we allow dynamic paths Good point, the reason I decided to reject it is because this way `insert`, `set` and `delete` are consistent and using the root path isn't really a manipulation/mutation, but rather an assignment (`set` is not needed just `val` is) and that particular scenario if needed could be done with a `CASE`. cc @srielau -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
