cloud-fan commented on code in PR #57202:
URL: https://github.com/apache/spark/pull/57202#discussion_r3573518409
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -87,6 +87,45 @@ object Connect {
.intConf
.createWithDefault(ConnectCommon.CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT)
+ val CONNECT_GRPC_KEEPALIVE_ENABLED =
+ buildStaticConf("spark.connect.grpc.keepAlive.enabled")
+ .doc(
+ "Whether the server sends gRPC/HTTP2 keepalive PINGs to detect and
terminate " +
+ "silently-dead client connections (see
spark.connect.grpc.keepAlive.time / " +
+ ".timeout). Enabled by default; can be turned off as an escape
hatch, e.g. if it " +
+ "interacts badly with a particular network path, or a server
environment is prone " +
+ "to stalls (long GC pauses, etc.) long enough to trip false-positive
disconnects.")
+ .version("4.3.0")
+ .booleanConf
+ .createWithDefault(ConnectCommon.CONNECT_GRPC_KEEPALIVE_ENABLED)
+
+ val CONNECT_GRPC_KEEPALIVE_TIME =
+ buildStaticConf("spark.connect.grpc.keepAlive.time")
+ .doc(
+ "Sets the time the server waits for the connection to be idle before
sending a " +
+ "gRPC/HTTP2 keepalive PING, to detect and terminate a silently-dead
connection " +
+ "(e.g. after a NAT gateway or load balancer drops an idle connection
mapping " +
+ "without closing the socket). Also used as the minimum interval the
server permits " +
+ "for keepalive PINGs sent by clients. Combined with " +
Review Comment:
Stale after the permit-decoupling fix: `permitKeepAliveTime` is now a fixed
10s `GRPC_KEEPALIVE_PERMIT_TIME_SECONDS`, independent of `keepAlive.time`, so
`keepAlive.time` is no longer the client-ping permit floor. You already
corrected this same claim in `docs/configuration.md` and
`client-connection-string.md`; this SQLConf doc string was missed — aligning it
with that wording:
```suggestion
"without closing the socket). The server separately tolerates
client-sent keepalive " +
"PINGs no more often than every 10s regardless of this setting.
Combined with " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
