anew commented on code in PR #57176:
URL: https://github.com/apache/spark/pull/57176#discussion_r3574459751
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/SqlGraphRegistrationContext.scala:
##########
@@ -162,6 +166,10 @@ class SqlGraphRegistrationContext(
case createStreamingTableCommand: CreateStreamingTable =>
// CREATE STREAMING TABLE [ streaming_table_name ] [ options ]
CreateStreamingTableHandler.handle(createStreamingTableCommand,
queryOrigin)
+ case createStreamingTableAutoCdcCommand: CreateStreamingTableAutoCdc =>
Review Comment:
I addressed this, and in the process discovered that the same issue existed
for a blank CREATE STREAMING TABLE (without a flow), and also for the CREATE
FLOW AS AUTO CDC. The latter actually resulted in a `CreateFlow` command with a
child `AutoCdcIntoCommand` that was a command in itself. I realized that this
should not be a command (because it can never occur by itself, only within a
CREATE FLOW), so I changed this to be named just `AutoCdcInto` and not
extending `Command` anymore. Also added tests for all these cases. I think this
is cleaner now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
