yadavay-amzn commented on code in PR #56932:
URL: https://github.com/apache/spark/pull/56932#discussion_r3574749178
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -890,6 +890,23 @@ object functions {
Column.fn("make_time", hour, minute, second)
}
+ /**
+ * Try to create time from hour, minute and second fields. The function
returns NULL on invalid
+ * inputs.
+ *
+ * @param hour
+ * the hour to represent, from 0 to 23
+ * @param minute
+ * the minute to represent, from 0 to 59
+ * @param second
+ * the second to represent, from 0 to 59.999999
+ * @group datetime_funcs
+ * @since 4.1.0
Review Comment:
Done
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -25580,6 +25580,54 @@ def make_time(hour: "ColumnOrName", minute:
"ColumnOrName", second: "ColumnOrNam
return _invoke_function_over_columns("make_time", hour, minute, second)
+@_try_remote_functions
+def try_make_time(hour: "ColumnOrName", minute: "ColumnOrName", second:
"ColumnOrName") -> Column:
+ """
+ Try to create time from hour, minute and second fields.
+ The function returns NULL on invalid inputs.
+
+ .. versionadded:: 4.1.0
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
