cloud-fan commented on code in PR #57235:
URL: https://github.com/apache/spark/pull/57235#discussion_r3580207422
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala:
##########
@@ -1351,6 +1354,20 @@ class DataSourceV2Suite extends SharedSparkSession with
AdaptiveSparkPlanHelper
"pushedFilters should contain the pushed filter on column i")
}
+ test("catalyst filter pushdown skips non-deterministic filters") {
Review Comment:
The throwing builder already exercises the fix (query optimization would
fail if `rand() > 0.5` reached `pushFilters`), so the guard is genuinely
tested. As optional strengthening, consider also asserting that the
nondeterministic filter survives as a post-scan `Filter` (or adding a
`checkAnswer`) so the post-scan retention is verified directly, not just the
absence from `pushedFilters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
