uros-b commented on code in PR #57187:
URL: https://github.com/apache/spark/pull/57187#discussion_r3583227722
##########
.github/workflows/maven_test.yml:
##########
@@ -222,21 +213,12 @@ jobs:
SPARK_LOCAL_IP: localhost
GITHUB_PREV_SHA: ${{ github.event.before }}
steps:
- - name: Checkout Spark repository
+ - name: Bootstrap composite actions
uses: actions/checkout@v6
- # In order to fetch changed files
+ - name: Checkout and sync Spark repository
+ uses: ./.github/actions/checkout-and-sync
with:
- fetch-depth: 0
- repository: apache/spark
- # Fall back to the branch when the precompile job failed before
resolving the SHA.
Review Comment:
Nit: the inline comment (# Fall back to the branch when the precompile job
failed before resolving the SHA.) that explained the head_sha || inputs.branch
fallback lived on the deleted ref: line and was dropped.
The fallback expression is preserved and correct, only the rationale is
lost. Consider re-adding the one-line comment on the composite call's ref:
input.
##########
.github/workflows/python_hosted_runner_test.yml:
##########
@@ -185,21 +176,12 @@ jobs:
BRANCH: ${{ inputs.branch }}
PYSPARK_TEST_TIMEOUT: 450
steps:
- - name: Checkout Spark repository
+ - name: Bootstrap composite actions
uses: actions/checkout@v6
- # In order to fetch changed files
+ - name: Checkout and sync Spark repository
+ uses: ./.github/actions/checkout-and-sync
with:
- fetch-depth: 0
- repository: apache/spark
- # Fall back to the branch when the precompile job failed before
resolving the SHA.
Review Comment:
Same as https://github.com/apache/spark/pull/57187/changes#r3583227722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
