cloud-fan commented on code in PR #57238:
URL: https://github.com/apache/spark/pull/57238#discussion_r3583888625
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SupportsArchiveFormatSuite.scala:
##########
@@ -86,7 +86,7 @@ class ArchiveReaderSuite extends SparkFunSuite {
* bit 3 is set and the local header's crc/size fields are zeroed, so the
real values live only in
* the trailing data descriptor. `ZipArchiveInputStream` cannot stream such
an entry -- it has no
* size to bound the read -- so `read` throws rather than yielding truncated
bytes. This is the
- * non-streamable case `ZipArchiveReader` documents;
`ZipArchiveOutputStream` cannot produce it
+ * non-streamable case the zip reader documents; `ZipArchiveOutputStream`
cannot produce it
Review Comment:
This says the non-streamable case is one "the zip reader documents", but
that documentation went away with the `ZipArchiveReader` class — its scaladoc
was where the trailing-data-descriptor case was described, and the new
`SupportsArchiveFormat` documents no such case. State the fact directly instead
of pointing at docs that no longer exist:
```suggestion
* non-streamable case for pure-streaming zip reads;
`ZipArchiveOutputStream` cannot produce it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
