srielau commented on PR #57251: URL: https://github.com/apache/spark/pull/57251#issuecomment-4981074845
Thanks @cloud-fan for the review — addressed in d6e12fa09d4: - **Blocking**: replaced `AsOfMatchCondition` with `matchLeftOperand` / `matchOperator` / `matchRightOperand` on `AsOfJoin` (no custom `mapExpressions` / `treePatternBits` overrides). Stacked analysis PR #57264 is rebased on top. - **Suggestions**: `AstBuilder` uses `sqlAsOfJoinEnabled`; unused error conditions are wired in #57264. - **Nits**: forward-reference scaladoc links fixed/removed. - **PR description**: added SQL vs DataFrame API asymmetry (tolerance / `Nearest`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
