jiangxt2 commented on PR #57211: URL: https://github.com/apache/spark/pull/57211#issuecomment-4981458068
Hi @marcuslin123, thanks for picking this up — the implementation looks great and follows the existing JSON function patterns really cleanly. I'm the original reporter of SPARK-57927. I see @yadavay-amzn left a few small inline suggestions (the lenient-parsing doc note, the null-check consistency nit, and pinning the single-quote behavior with a test case). If you're open to it, I'd love to help address those and push to your branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
