stevomitric commented on code in PR #57085:
URL: https://github.com/apache/spark/pull/57085#discussion_r3596663213
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala:
##########
@@ -1739,6 +1739,50 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(UnixMicros(Literal(timestampWithNanos)), 1000001L)
}
+ test("SPARK-57814: unix_seconds / unix_millis / unix_micros over " +
+ "NTZ and nanosecond-precision timestamps") {
+ import org.apache.spark.sql.catalyst.util.TimestampNanosTestUtils._
+
+ // 2008-12-25 15:30:00.123456789 -> epochMicros 1230219000123456 (+789 ns
remainder dropped).
+ // unix_* apply no zone shift, so the NTZ wall-clock value and the LTZ
instant at the same UTC
+ // reading produce identical results.
+ val ntz = localDateTimeToNanosVal(timestampNTZ(2008, 12, 25, 15, 30, 0,
123456789))
+ val ltz =
instantToNanosVal(Instant.parse("2008-12-25T15:30:00.123456789Z"))
+ foreachNanosPrecision { p =>
+ checkEvaluation(UnixSeconds(Literal.create(ntz,
TimestampNTZNanosType(p))), 1230219000L)
+ checkEvaluation(UnixSeconds(Literal.create(ltz,
TimestampLTZNanosType(p))), 1230219000L)
+ checkEvaluation(UnixMillis(Literal.create(ntz,
TimestampNTZNanosType(p))), 1230219000123L)
+ checkEvaluation(UnixMillis(Literal.create(ltz,
TimestampLTZNanosType(p))), 1230219000123L)
+ checkEvaluation(UnixMicros(Literal.create(ntz,
TimestampNTZNanosType(p))), 1230219000123456L)
+ checkEvaluation(UnixMicros(Literal.create(ltz,
TimestampLTZNanosType(p))), 1230219000123456L)
+ }
+
+ // Micro TIMESTAMP_NTZ is now accepted directly and read as a physical
Long with no zone shift.
+ // It was NOT rejected before this change: implicit coercion silently cast
it to TIMESTAMP_LTZ,
Review Comment:
fixed comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
