szehon-ho commented on PR #57245: URL: https://github.com/apache/spark/pull/57245#issuecomment-4995521308
One more thing worth calling out about the latent bug: keying on `f.identifier` didn't only *skip* validation for named flows, it could validate the *wrong* table. If a named flow's identifier happened to collide with some other table's identifier, the old `table.get(f.identifier)` would pull up that unrelated table and validate it, while the flow's actual destination table went unchecked. Keying on the destination identifier removes that misattribution too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
