cloud-fan commented on code in PR #57308:
URL: https://github.com/apache/spark/pull/57308#discussion_r3607080121
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/columnNodes.scala:
##########
@@ -666,10 +666,21 @@ case class SubqueryExpression(
subqueryType: SubqueryType,
override val origin: Origin = CurrentOrigin.get)
extends ColumnNode {
+ override private[internal] def normalize(): SubqueryExpression = copy(
Review Comment:
Please add this node to the normalization contract coverage in
`ColumnNodeSuite`. The new execution tests exercise `children`, but they do not
verify origin stripping or recursive normalization of `IN(values)`, so this
separately introduced equality/hash behavior could regress unnoticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
