uros-b commented on code in PR #57291:
URL: https://github.com/apache/spark/pull/57291#discussion_r3614020428
##########
python/pyspark/sql/tests/connect/test_connect_session.py:
##########
@@ -115,6 +115,16 @@ def test_stop_session(self):
self.spark.conf.get("some.conf")
self._check_no_active_session_error(e.exception)
+ def test_with_block(self):
Review Comment:
test_with_block omits the @timeout(10) decorator carried by the sibling
tests that make gRPC calls (test_progress_handler, test_stop_session,
test_custom_channel_builder). Those decorators were added by a dedicated commit
(64785022e70, zhengruifeng) specifically after a CI hang on connect-session
tests. test_with_block runs session.sql(...).collect() and session.stop() over
the channel, so it carries the same hang risk; without the decorator a stuck
call could stall the whole run. Please add @timeout(10).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
