LuciferYang opened a new pull request, #57393:
URL: https://github.com/apache/spark/pull/57393

   ### What changes were proposed in this pull request?
   
   Fix the jQuery import path in `ui-test/tests/executorspage.test.js` on 
`branch-4.1`, changing `jquery.min.js` to `jquery-3.5.1.min.js`.
   
   ### Why are the changes needed?
   
   The `executorspage.test.js` added by SPARK-58158 imports `jquery.min.js`. 
That file name only exists on `master`, where SPARK-54235 (a master-only jQuery 
3.5.1 -> 3.7.1 upgrade) renamed `jquery-3.5.1.min.js` to the version-agnostic 
`jquery.min.js`. SPARK-54235 was not backported, so on `branch-4.1` the file is 
still `jquery-3.5.1.min.js` and the import fails:
   
   ```
   FAIL tests/executorspage.test.js
     Cannot find module '.../ui/static/jquery.min.js' from 
'tests/executorspage.test.js'
   ```
   
   This breaks the daily "Run Spark UI tests" job on `branch-4.1` (e.g. 
https://github.com/apache/spark/actions/runs/29675755877/job/88162850620). The 
other three ui-test files on this branch already import `jquery-3.5.1.min.js`; 
this aligns `executorspage.test.js` with them. The `jquery.dataTables.min.js` 
import on the following line is unaffected (that file exists on the branch).
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test-only.
   
   ### How was this patch tested?
   
   Ran the ui-test suite locally on `branch-4.1` with the fix:
   
   ```
   cd ui-test
   npm install --save-dev
   node --experimental-vm-modules node_modules/.bin/jest
   
   Test Suites: 5 passed, 5 total
   Tests:       13 passed, 13 total
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to