uros-b commented on code in PR #57358:
URL: https://github.com/apache/spark/pull/57358#discussion_r3621668436
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala:
##########
@@ -1536,7 +1536,7 @@ class StatisticsSuite extends
StatisticsCollectionTestBase with TestHiveSingleto
Seq(tbl, ext_tbl).foreach { tblName =>
sql(s"INSERT INTO $tblName VALUES (1, 'a', '2019-12-13')")
- val expectedSize = 657
Review Comment:
The fix again hardcodes another magic byte count (658), preserving the
fragility that caused this issue.
It will fail again on any future version-string-length change or Parquet
bump on 3.5.
A better fix (SPARK-53422) is already merged on master. Should we consider
cherry picking it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
