cloud-fan commented on code in PR #57306: URL: https://github.com/apache/spark/pull/57306#discussion_r3622825837
########## sql/core/src/test/resources/sql-tests/inputs/join-asof-containers.sql: ########## @@ -0,0 +1,186 @@ +-- FVT Category 7: ASOF JOIN container integration (FVT-ASOF-7-*) +-- Source: sql-fvt-plan/plans/asof-join.md + +--SET spark.sql.join.asofJoin.enabled=true + +CREATE OR REPLACE TEMP VIEW trades(trade_time, symbol, quantity) AS + VALUES (TIMESTAMP '2026-06-29 10:00:05', 'AAPL', 100), + (TIMESTAMP '2026-06-29 10:00:11', 'AAPL', 200), + (TIMESTAMP '2026-06-29 10:00:12', 'MSFT', 50), + (TIMESTAMP '2026-06-29 09:59:59', 'GOOG', 30); + +CREATE OR REPLACE TEMP VIEW quotes(quote_time, symbol, bid_price) AS + VALUES (TIMESTAMP '2026-06-29 10:00:00', 'AAPL', 180.10), + (TIMESTAMP '2026-06-29 10:00:07', 'AAPL', 180.15), + (TIMESTAMP '2026-06-29 10:00:10', 'AAPL', 180.20), + (TIMESTAMP '2026-06-29 10:00:08', 'MSFT', 420.50); + +-- FVT-ASOF-7-001: temp view hosting ASOF +CREATE OR REPLACE TEMP VIEW asof_matched_v AS +SELECT t.trade_time, q.bid_price +FROM trades t ASOF JOIN quotes q + MATCH_CONDITION (t.trade_time >= q.quote_time) + ON t.symbol = q.symbol; + +SELECT count(*) AS cnt FROM asof_matched_v; + +-- FVT-ASOF-7-002: permanent view hosting ASOF Review Comment: This case, 7-006, and 7-007 all fail object creation with `INVALID_TEMP_OBJ_REFERENCE` because they reference the temporary `trades`/`quotes` views. The follow-up queries then only confirm that the objects were not created, so none of the three cases exercises ASOF inside the advertised container. Please use permanent tables or self-contained `VALUES` inputs and regenerate the goldens so these cases reach ASOF analysis/execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
