dongjoon-hyun commented on code in PR #56628:
URL: https://github.com/apache/spark/pull/56628#discussion_r3623931198
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -254,6 +254,7 @@ class JsonProtocolSuite extends SparkFunSuite {
testTaskEndReason(TaskKilled("test"))
testTaskEndReason(TaskCommitDenied(2, 3, 4))
testTaskEndReason(ExecutorLostFailure("100", true, Some("Induced
failure")))
+ testTaskEndReason(ExecutorShutdownFailure("exec-42"))
Review Comment:
Could you add a real back-combat deserialization test case like you describe
in the PR description?
> ### How was this patch tested?
> JsonProtocolSuite: round-trip serialization and back-compat
deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
