dongjoon-hyun commented on code in PR #56675:
URL: https://github.com/apache/spark/pull/56675#discussion_r3624155744
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3160,10 +3160,12 @@ object SQLConf {
.createWithDefault(false)
val MIN_BATCHES_TO_RETAIN =
buildConf("spark.sql.streaming.minBatchesToRetain")
- .internal()
- .doc("The minimum number of batches that must be retained and made
recoverable.")
+ .doc("The minimum number of batches that must be retained and made
recoverable. " +
+ "This also controls the lifecycle of checkpoint files: state and offset
log files older " +
+ "than this many batches are eligible for cleanup. Must be positive.")
Review Comment:
`commit log` is missing. Please update like the following.
```suggestion
"This also controls the lifecycle of checkpoint files: state, offset
and commit log " +
"files older than this many batches are eligible for cleanup. Must be
positive.")
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3160,10 +3160,12 @@ object SQLConf {
.createWithDefault(false)
val MIN_BATCHES_TO_RETAIN =
buildConf("spark.sql.streaming.minBatchesToRetain")
- .internal()
- .doc("The minimum number of batches that must be retained and made
recoverable.")
+ .doc("The minimum number of batches that must be retained and made
recoverable. " +
+ "This also controls the lifecycle of checkpoint files: state and offset
log files older " +
+ "than this many batches are eligible for cleanup. Must be positive.")
.version("2.1.1")
.intConf
+ .checkValue(_ > 0, "minBatchesToRetain must be positive")
Review Comment:
Since we have this, please remove the following.
https://github.com/apache/spark/blob/8a33fb73fa520ba04be46a1c350e46d79234b53c/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/StreamExecution.scala#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
