karuppayya commented on code in PR #57355:
URL: https://github.com/apache/spark/pull/57355#discussion_r3626410644
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala:
##########
@@ -343,7 +362,8 @@ object ShuffleExchangeExec {
outputAttributes: Seq[Attribute],
newPartitioning: Partitioning,
serializer: Serializer,
- writeMetrics: Map[String, SQLMetric])
+ writeMetrics: Map[String, SQLMetric],
+ customWriteMetrics: Map[String, SQLMetric] = Map.empty)
Review Comment:
Good catch, thanks @uros-b — fixed.
- All three operators now create collision-filtered custom metrics, expose
them in metrics, and pass them to prepareShuffleDependency.
- Extracted a shared `ShuffleMetricsSupport` trait +
`CustomShuffleMetrics.createFilteredMetrics` helper
to avoid repeating the plumbing.
- Removed the `Map.empty` default on `prepareShuffleDependency` /
`createShuffleWriteProcessor` so a
future caller that forgets to wire metrics gets a compile error .
- Added a regression test for a multi-partition limit shuffle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
