Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r32379896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -254,3 +255,46 @@ case class Pow(left: Expression, right: Expression)
"""
}
}
+
+case class Pmod(left: Expression, right: Expression) extends
BinaryArithmetic {
+
+ override def symbol: String = "pmod"
+
+ override def toString: String = s"pmod($left, $right)"
+
+ protected def checkTypesInternal(t: DataType) =
+ TypeUtils.checkForNumericExpr(t, "pmod")
+
+ override lazy val resolved =
+ childrenResolved && checkInputDataTypes().isSuccess &&
!DecimalType.isFixed(dataType)
+
+ protected override def evalInternal(left: Any, right: Any) =
+ dataType match {
+ case IntegerType => pmod(left.asInstanceOf[Integer],
right.asInstanceOf[Integer] )
+ case ShortType => pmod(left.asInstanceOf[Short],
right.asInstanceOf[Short] )
+ case FloatType => pmod(left.asInstanceOf[Float],
right.asInstanceOf[Float] )
+ case DoubleType => pmod(left.asInstanceOf[Double],
right.asInstanceOf[Double] )
+ case _ => null
--- End diff --
according to
[hive](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java),
I think we need to support `Decimal`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
