anew commented on code in PR #57412:
URL: https://github.com/apache/spark/pull/57412#discussion_r3633620869
##########
python/pyspark/pipelines/api.py:
##########
@@ -536,7 +536,9 @@ def create_auto_cdc_flow(
apply_as_deletes: Optional[Union[str, Column]] = None,
column_list: Optional[Union[List[str], List[Column]]] = None,
except_column_list: Optional[Union[List[str], List[Column]]] = None,
- stored_as_scd_type: Optional[Literal[1, "1"]] = None,
+ stored_as_scd_type: Optional[Literal[1, 2, "1", "2"]] = None,
+ track_history_column_list: Optional[Union[List[str], List[Column]]] = None,
Review Comment:
The new track_history_* parameters are inserted before the
existing name parameter in a public function that accepts positional
arguments. Existing calls that
pass name positionally now bind that string to
track_history_column_list, then fail validation as
“expected list[str] or list[Column]”. To preserve compatibility, keep
name in its old positional slot
and add the new parameters after it, ideally keyword-only:
```
name: Optional[str] = None,
*,
track_history_column_list: Optional[...] = None,
track_history_except_column_list: Optional[...] = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
