Spenserrrr commented on PR #57435: URL: https://github.com/apache/spark/pull/57435#issuecomment-5054946023
Thanks both for the review! I just pushed some changes addressing the feedback: - date_as_object: I added as a second output column (date_as_object=False) on the date rows. The matrix applies one conversion uniformly across all rows, so we may need to have a separate golden file or special-case logic if we want to add tests as rows. Columns fit better here. - duration overflow: added duration[s]:overflow. Note that it does not raise like timestamp[s]:overflow. An out-of-range duration silently wraps to a bogus value. - pyarrow 18-25: verified the recorded cells are identical across all supported versions - file structure: refactor the file with a shared base class and one subclass per flag that brings its own source arrays and test method. Thus, future flags (zero_copy_only) can fit in without new files. - centralizing the matrix helper into GoldenFileTestMixin: proposing a separate follow-up PR since it also touches the default and array_cast tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
