Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/6804#issuecomment-111865642
@davies thanks for your feedback.
I added a null check and test cases for null. There are other public
methods without null checks. Should I add a null check to them as well?
I did a micro benchmark for starsWith. I created objects for the UTF8String
and called the test 1,000,000,000 times.
duration starts with old: 73,586 ms
duration starts with new: 23,246 ms (just 31.6%)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
