dongjoon-hyun commented on code in PR #57485:
URL: https://github.com/apache/spark/pull/57485#discussion_r3646492680
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -517,6 +517,129 @@ class InjectRuntimeFilterSuite extends SharedSparkSession
}
}
+ test("SPARK-58310: preserve Python UDFs in runtime bloom-filter scalar
subqueries") {
+ import IntegratedUDFTestUtils._
+
+ assume(shouldTestPythonUDFs)
+ registerTestUDF(TestPythonUDF("normalize_runtime_bloom_url"), spark)
+ val pythonUdfNames = if (shouldTestPandasUDFs) {
+
registerTestUDF(TestScalarPandasUDF("normalize_runtime_bloom_pandas_url"),
spark)
+ Seq("normalize_runtime_bloom_url", "normalize_runtime_bloom_pandas_url")
+ } else {
+ Seq("normalize_runtime_bloom_url")
+ }
+
+ withTempPath { dir =>
+ val factPath = new java.io.File(dir, "fact").getCanonicalPath
+ val dimensionPath = new java.io.File(dir, "dimension").getCanonicalPath
Review Comment:
Please use `import java.io.File` and revise the following.
```suggestion
val factPath = new File(dir, "fact").getCanonicalPath
val dimensionPath = new File(dir, "dimension").getCanonicalPath
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
