venkata91 commented on PR #57219:
URL: https://github.com/apache/spark/pull/57219#issuecomment-5075849532
Pushed `0033c90`.
**Empty user id (`ConnectResource`):** good catch. `sessions/{sessionId}`
now rejects only an absent `userId` parameter; a present-but-empty token
decodes to the empty user, so sessions created with the protobuf-default empty
user id are addressable again. Added a test that seeds an empty-user session
and asserts the detail endpoint resolves it (and that an absent parameter still
returns 400).
**Legacy History Server stores (P2-a):** thanks for the discussion. Keeping
the `getSession` field-scan fallback as-is, with the documented limitation that
pre-upgrade rows already collapsed under the old `sessionId`-only key can't be
reconstructed without replay.
The earlier CI failure was an unrelated port-bind flake in
`SparkConnectServiceInternalServerSuite` ("retry using different ports",
`BindException` on 15002), not touched by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
