Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/6774#issuecomment-111883784
  
    Yes, this is a lot more inline with what I was thinking before. Thanks for 
making the change.
    
    One thing I noticed is that `SparkConf.isExecutorStartupConf` is unchanged. 
It should not include the secret in the list of options to pass on an 
executor's command line.
    
    (Note I'll be out for about 10 days so I won't be able to follow up on 
reviews.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to