sarutak commented on PR #57387: URL: https://github.com/apache/spark/pull/57387#issuecomment-5084689771
> It seems that we missed the configuration namespace conflict issue during SPIP discussion. > > Technically, `spark.security.credentials.*` is the namespace for `Hadoop delegation token` in Apache Spark. > > https://github.com/apache/spark/blob/b910d6f4101c53dd5f9b866122d92e4c41c768f3/core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala#L296 > > So, the proposed configuration namespace is very misleading to the Apache Spark users. If you don't mind, I'd like to propose to use `spark.security.oidc.*` namespace for this **SPIP: OIDC Credential Propagation**. > > WDYT, @sarutak ? Thanks for catching this, @dongjoon-hyun. I agree that reusing the `spark.security.credentials.*` for OIDC creates confusion. I'll rename to `spark.security.oidc.*` as you suggest. Since the earlier sub-tasks (already merged) also reference the old namespace in `CredentialProviderLoader`, `CredentialProvider`, and `FileTokenIngestor`, I'll submit a preparatory PR to rename those first. Once that's merged, I'll rebase this PR with the full namespace update and address your other comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
