uros-b commented on code in PR #57557:
URL: https://github.com/apache/spark/pull/57557#discussion_r3657719729
##########
core/src/main/java/org/apache/spark/security/CredentialProviderLoader.java:
##########
@@ -66,14 +66,14 @@ public final class CredentialProviderLoader {
* When set (non-empty), the configured fully-qualified class name must
match a discovered
* provider that supports the scheme; a mismatch results in an {@link
IllegalArgumentException}.
*/
- private static final String CONF_PREFIX =
"spark.security.credentials.provider.";
+ private static final String CONF_PREFIX = "spark.security.oidc.provider.";
/**
* Configuration key prefix used to scope the configuration passed to
* {@link CredentialProvider#init(Map)}. Only keys starting with this prefix
are forwarded,
* preventing unrelated secrets from leaking to third-party provider
implementations.
*/
- private static final String CREDENTIALS_CONF_PREFIX =
"spark.security.credentials.";
+ private static final String CREDENTIALS_CONF_PREFIX = "spark.security.oidc.";
Review Comment:
The identifier here still reads CREDENTIALS, even though the value has been
updated to "spark.security.oidc." - please finish the cleanup accordingly and
also make sure to remove any potentially misleading in-code documentation at
read sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
