LuciferYang commented on PR #56700: URL: https://github.com/apache/spark/pull/56700#issuecomment-5093318890
> +1, LGTM. BTW, shall we remove the following sentence, `A dedicated test is not included ...`, because this PR added two new test cases, @LuciferYang ? > > > ### How was this patch tested? > > A dedicated test is not included because asserting the absence of a busy-wait reliably requires CPU-time or timing measurements that are flaky in CI. Thank you @dongjoon-hyun . I have update the `How was this patch tested?` section to describe the new tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
