haoyangeng-db opened a new pull request, #57618:
URL: https://github.com/apache/spark/pull/57618

   ### What changes were proposed in this pull request?
   
   Add a catch-all `case _ =>` as the final arm to a few 
SparkListener.onOtherEvent match blocks in test suites that enumerate only the 
specific event type(s) they care about and omit a catch-all: 
PluginContainerSuite, SQLExecutionSuite (jobTags / jobGroupId tests), and 
SparkConnectServiceInternalServerSuite.
   
   ### Why are the changes needed?
   
   SparkListenerBus.doPostEvent routes every non-built-in event to 
onOtherEvent, so a shared-queue listener receives all such events, not just the 
ones it enumerates. A match block with no `case _ =>` throws a scala.MatchError 
on every other event; ListenerBus.postToAll logs and swallows it, so tests pass 
but the logs are spammed with MatchError stack traces. The catch-all matches 
the convention the built-in listeners already follow and is always added last, 
so it never shadows an existing case.
   
   ### How was this patch tested?
   
   This change is test-only.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Co-authored w/ Claude Code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to