szehon-ho commented on code in PR #57610:
URL: https://github.com/apache/spark/pull/57610#discussion_r3670534146
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/ChangeArgs.scala:
##########
@@ -127,8 +131,13 @@ private[pipelines] object CaseSensitivityLabels {
val CaseSensitive: String = "case-sensitive"
val CaseInsensitive: String = "case-insensitive"
- def of(caseSensitive: Boolean): String =
- if (caseSensitive) CaseSensitive else CaseInsensitive
+ /**
+ * Maps a [[Resolver]] to its user-facing label. Classifies by reference
identity against the
+ * two session resolver singletons, matching
`SchemaUtils.isCaseSensitiveAnalysis`;
Review Comment:
nit: it doesnt match SchemaUtils.isCaseSensitiveAnalysis which throws for
unknown resolvers. should we just remove such comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
