nchammas commented on code in PR #55281: URL: https://github.com/apache/spark/pull/55281#discussion_r3678867445
########## dev/spark_jira_utils.py: ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import os +import re +import sys + +try: + import jira.client + + JIRA_IMPORTED = True +except ImportError: + JIRA_IMPORTED = False + +# ASF JIRA access token +JIRA_ACCESS_TOKEN = os.environ.get("JIRA_ACCESS_TOKEN") +JIRA_API_BASE = "https://issues.apache.org/jira"; + + +def fail(msg): + print(msg) + sys.exit(-1) + + +def get_jira_client(): + """Create and return a JIRA client, or exit with a helpful message.""" + errors = [] + if not JIRA_IMPORTED: + errors.append("jira-python library not installed, run 'pip install jira'") Review Comment: For dev utilities like this, I think a fantastic improvement is to use [inline script dependencies](https://packaging.python.org/en/latest/specifications/inline-script-metadata/#inline-script-metadata). Then, instead of having to try the import, raise an error, manually pip install, etc. devs can just run: ``` uv run dev/create_spark_jira.py ``` And it will automatically download the dependencies in an isolated fashion and then run the script. Subsequent runs will use the cached (and isolated!) dependencies and immediately run the script. Would you be interested in a PR to make this change? (`uv` is not the only tool that supports inline script dependencies, but it is by far the most popular one.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
