aokolnychyi commented on code in PR #57582:
URL: https://github.com/apache/spark/pull/57582#discussion_r3678924078
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -484,24 +485,21 @@ private[sql] object CatalogV2Util {
catalog: CatalogPlugin,
ident: Identifier,
timeTravelSpec: Option[TimeTravelSpec] = None,
- writePrivilegesString: Option[String] = None): Table = {
- if (timeTravelSpec.nonEmpty) {
- assert(writePrivilegesString.isEmpty, "Should not write to a table with
time travel")
- timeTravelSpec.get match {
- case v: AsOfVersion =>
- catalog.asTableCatalog.loadTable(ident, v.version)
- case ts: AsOfTimestamp =>
- catalog.asTableCatalog.loadTable(ident, ts.timestamp)
- }
- } else {
- if (writePrivilegesString.isDefined) {
- val writePrivileges = writePrivilegesString.get.split(",").map(_.trim)
- .map(TableWritePrivilege.valueOf).toSet.asJava
- catalog.asTableCatalog.loadTable(ident, writePrivileges)
- } else {
- catalog.asTableCatalog.loadTable(ident)
- }
+ writePrivilegesString: Option[String] = None,
+ options: CaseInsensitiveStringMap = CaseInsensitiveStringMap.empty()):
Table = {
+ val timeTravel: TimeTravel = timeTravelSpec match {
+ case Some(v: AsOfVersion) => new TimeTravel.Version(v.version)
+ case Some(ts: AsOfTimestamp) => new TimeTravel.Timestamp(ts.timestamp)
+ case None => null
+ }
+ val writePrivileges: util.Set[TableWritePrivilege] = writePrivilegesString
match {
Review Comment:
Optional: Is there a good utility method to put this conversion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
