aokolnychyi commented on code in PR #57487:
URL: https://github.com/apache/spark/pull/57487#discussion_r3686304224
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala:
##########
@@ -199,15 +201,32 @@ case class DataSourceV2ScanRelation(
}
override def computeStats(): Statistics = {
- scan match {
- case r: SupportsReportStatistics =>
- val statistics = r.estimateStatistics()
- DataSourceV2Relation.transformV2Stats(statistics, None,
conf.defaultSizeInBytes, output)
- case _ =>
- Statistics(sizeInBytes = conf.defaultSizeInBytes)
+ if (conf.cboEnabled || conf.planStatsEnabled) {
+ computeFullStats()
+ } else {
+ computeSizeOnlyStats()
+ }
+ }
+
+ private def computeFullStats(): Statistics = {
+ V2StatisticsUtils.computeStats(scan) match {
+ case Some(v2Stats) =>
+ DataSourceV2Relation.transformV2Stats(v2Stats,
conf.defaultSizeInBytes, output)
+ case _ => defaultSizeOnlyStats
+ }
+ }
+
+ private def computeSizeOnlyStats(): Statistics = {
+ V2StatisticsUtils.computeSizeInBytes(scan,
EstimationUtils.getSizePerRow(output)) match {
Review Comment:
Can we have a separate variable for `EstimationUtils.getSizePerRow(output)`?
```
val avgRowSize = EstimationUtils.getSizePerRow(output)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
