sunchao commented on code in PR #57437:
URL: https://github.com/apache/spark/pull/57437#discussion_r3687362963


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala:
##########
@@ -110,6 +110,11 @@ object PartitionPruning extends Rule[LogicalPlan] with 
PredicateHelper with Join
     require(filteringKeys.size == 1, "DPP Filters should only have a single 
broadcasting key " +
       "since there are no usage for multiple broadcasting keys at the moment.")
     val indices = Seq(joinKeys.indexOf(filteringKeys.head))
+    val broadcastValueProjection = if 
(conf.dynamicPartitionPruningBroadcastProjectionEnabled) {
+      ReusableBroadcastValueProjection.find(filteringKeys.head, filteringPlan, 
partScan)

Review Comment:
   Thanks @peter-toth. This is now addressed with the `@transient` 
second-parameter-list approach on both `DynamicPruningSubquery` and 
`SubqueryAdaptiveBroadcastExec`. `otherCopyArgs` carries the metadata through 
Catalyst rewrites without changing product arity, equality, or 
canonicalization. I kept the explicit handoff so the exact pruned-leaf 
exclusion remains available consistently to both adaptive and nonadaptive 
planning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to