zhengruifeng commented on PR #57587: URL: https://github.com/apache/spark/pull/57587#issuecomment-5138786692
Thanks for this work. I have two questions/concerns. First, regarding the new Grimp dependency: how reliable and accurate is its import analysis for a project like PySpark? Do we know of other large projects using it in CI for test selection? It would be useful to understand its maintenance record, compatibility guarantees, and real-world adoption before adding it as a dependency. Second, I am fine with using smart selection in post-merge CI to save resources. However, pre-merge CI is the merge gate, so we should enable it there only when we are confident that the analysis cannot skip an impacted test. In particular, we need to account for dynamic imports and other indirect dependencies, and fall back to running tests whenever the result is uncertain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
