Spenserrrr commented on code in PR #57611:
URL: https://github.com/apache/spark/pull/57611#discussion_r3687929672
##########
python/pyspark/sql/connect/streaming/readwriter.py:
##########
@@ -510,13 +510,15 @@ def partitionBy(self, *cols: str) -> "DataStreamWriter":
...
@overload
def partitionBy(self, __cols: List[str]) -> "DataStreamWriter": ...
- def partitionBy(self, *cols: str) -> "DataStreamWriter": # type:
ignore[misc]
+ def partitionBy(self, *cols: Union[str, List[str]]) -> "DataStreamWriter":
Review Comment:
Agreed. I found this pattern is scattered across many methods in several
files, and I saw that your SPARK-55967 (PR #54764) already tried to solve it.
As it may affect a lot of files, I've reverted the partitionBy/clusterBy change
back, and I think it may be better to open a separate PR for it. I will study
your approach and follow the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
