cloud-fan commented on code in PR #57414:
URL: https://github.com/apache/spark/pull/57414#discussion_r3688650549
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SevenZArchiveReadBase.scala:
##########
@@ -68,4 +68,12 @@ trait SevenZArchiveTestUtils {
protected def writeCorruptArchive(dest: File): Unit =
Files.write(dest.toPath, "this is not a valid 7z archive, just some random
bytes"
.getBytes(StandardCharsets.UTF_8))
+
+ // 7z validates its whole index when the archive is opened, so it can only
fail at open, never
Review Comment:
Please narrow this to the failure shape the helper cannot synthesize.
`SevenZFile` can still fail after open while reading entry bytes, so the
current wording overstates the production contract.
```suggestion
// 7z validates its whole index when the archive is opened, so this helper
cannot construct a
// failure that occurs only while advancing to another entry.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
