ericm-db opened a new pull request, #57687:
URL: https://github.com/apache/spark/pull/57687

   ### What changes were proposed in this pull request?
   
   This is layer 4 of the local Connect pool stack: #57684 -> #57685 -> #57686 
-> this PR. Until the lower layers merge, GitHub shows their cumulative diff; 
the new review unit here is commit `f3a02502293`.
   
   This layer adds the acquisition engine:
   
   - claim, refill, retry, and timeout handling;
   - detached member attendants;
   - ephemeral local Connect server boot and publication;
   - per-fingerprint pool sizing;
   - attendant supervision and cleanup;
   - process-exit release registration; and
   - internal `--attend` plus user-invoked `--purge` entry points.
   
   SparkSession integration and JIT warmup remain in later PRs.
   
   ### Why are the changes needed?
   
   The storage and lifecycle layers define safe state transitions, but a pool 
also needs one owner for launching and supervising each server. Isolating that 
orchestration makes the attendant boundary, environment sanitization, retry 
behavior, and refill concurrency independently reviewable.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. The acquisition engine is not selected by SparkSession in this layer.
   
   ### How was this patch tested?
   
   Expanded `LocalConnectServerPoolUnitTests` with acquisition coverage for 
fingerprint-aware refill, re-entrant acquisition of an existing claim, and the 
POSIX platform gate, in addition to all storage and lifecycle cases.
   
   ```bash
   python -m unittest -v 
pyspark.sql.tests.connect.test_connect_local_server_pool.LocalConnectServerPoolUnitTests
   ```
   
   All 17 tests passed. Ruff check, Ruff format check, and `git diff --check` 
also passed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Fable 5) and OpenAI Codex (GPT-5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to