anew commented on code in PR #56671:
URL: https://github.com/apache/spark/pull/56671#discussion_r3694627368
##########
python/pyspark/pipelines/api.py:
##########
@@ -538,6 +538,7 @@ def create_auto_cdc_flow(
except_column_list: Optional[Union[List[str], List[Column]]] = None,
stored_as_scd_type: Optional[Literal[1, 2, "1", "2"]] = None,
name: Optional[str] = None,
+ spark_conf: Optional[Dict[str, str]] = None,
Review Comment:
`spark_conf` is added before `*`, so it becomes positional-or-keyword. If
this intentional?
If the intent is strictly a new kwarg, it should be placed after `*` with
the existing keyword-only tracking column arguments. The peer APIs
(append_flow, table, etc.) all declare spark_conf after the `*` (keyword-only).
Here it's positional-or-keyword (placed before `*`). It's still
backwards-compatible, but moving it after the `*` would match the established
pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
