uros-b commented on code in PR #57682:
URL: https://github.com/apache/spark/pull/57682#discussion_r3702828452
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionSuite.scala:
##########
@@ -686,6 +686,16 @@ class VariantExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
// scalastyle:on nonascii
testVariantGet("[1, 2, 3]", "$[2147483647]", IntegerType, null)
+ Seq("variant_get" -> true, "try_variant_get" -> false).foreach {
+ case (name, failOnError) =>
+ checkErrorInExpression[SparkRuntimeException](
+ VariantGet(BoundReference(0, VariantType, nullable = true),
Literal(".a"),
+ IntegerType, failOnError),
+ InternalRow(null),
+ "INVALID_VARIANT_GET_PATH",
Review Comment:
Should this be INVALID_VARIANT_PATH, or should the PR title be updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
