ueshin commented on PR #57504:
URL: https://github.com/apache/spark/pull/57504#issuecomment-5167686733
LGTM.
The old behavior is for pandas 3.0.0 to somewhere below 3.0.5, so I guess we
can just drop this behavior as pandas thought this was a bug to fix during
maintenance releases; otherwise need to put the upperbound to the `if`
condition. cc @gaogaotiantian
- with this patch on pandas 3.0.0:
```sh
% ./python/run-tests --python-executables=python --testname
'pyspark.pandas.tests.indexes.test_indexing_loc
IndexingLocTests.test_frame_loc_setitem'
...
pyspark.errors.exceptions.base.PySparkAssertionError:
[DIFFERENT_PANDAS_DATAFRAME] DataFrames are not almost equal:
Left:
max_speed shield
cobra 1 2
viper 10 10
sidewinder 10 10
max_speed int64
shield int64
dtype: object
Right:
max_speed shield
cobra 1 2
viper 4 5
sidewinder 7 8
max_speed int64
shield int64
dtype: object
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
