Spenserrrr commented on PR #57726: URL: https://github.com/apache/spark/pull/57726#issuecomment-5170433102
Hi @gaogaotiantian! This is the third PR from the #57611 follow-up. Also, there are two things that I want to point out: - It adds two # type: ignore[arg-type] in the connect Window static methods, which forward their varargs into the now-overloaded WindowSpec methods. This is the same as the existing DataFrame.agg function. - @HyukjinKwon has raised a question on #57702 about whether we should be annotating this pattern at all and deprecating the single-collection form. That applies to this PR too, so it may be worth settling there first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
