alekjarmov commented on code in PR #57720: URL: https://github.com/apache/spark/pull/57720#discussion_r3710961236
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala: ########## @@ -221,7 +221,35 @@ private case class MySQLDialect() extends JdbcDialect with SQLConfHelper with No // See https://dev.mysql.com/doc/mysql-errors/8.0/en/server-error-reference.html override def isSyntaxErrorBestEffort(exception: SQLException): Boolean = { - "42000".equals(exception.getSQLState) + "42000".equals(exception.getSQLState) && + !isNonSyntaxErrorBestEffort(exception) Review Comment: The problem with this is that there are 144 errors with "42000" errors and the majority of them are syntax errors , so if we go with the allowlist approach we either have some allowlist of 80 entires which seems like too much to maintain or miss a lot of them. I think this would be more accurate in general but I can swap to allowlist if you still think it's better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
