uros-b commented on code in PR #57736:
URL: https://github.com/apache/spark/pull/57736#discussion_r3712839544
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -351,7 +351,7 @@ private[spark] class ApplicationMaster(
*/
final def getDefaultFinalStatus(): FinalApplicationStatus = {
if (isClusterMode) {
- FinalApplicationStatus.FAILED
+ FinalApplicationStatus.SUCCEEDED
Review Comment:
This inverts a FAIL-SAFE default, and the justification rests on a STALE
docstring rather than the code's intent. The FAILED default was set
deliberately in SPARK-38270; the docstring mentioning SUCCEEDED predates that
change and was not updated. The real defect is the comment, not the code. This
PR resolves the mismatch in the wrong direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
