wangyum commented on code in PR #57525:
URL: https://github.com/apache/spark/pull/57525#discussion_r3713382723
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2695,6 +2695,20 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val EXECUTOR_IDENTITY_VERIFICATION_ENABLED =
+ ConfigBuilder("spark.executor.identityVerification.enabled")
+ .doc("When enabled, the driver validates the executor's application ID
before " +
+ "returning bootstrap credentials (I/O encryption key, Hadoop
delegation " +
+ "tokens) and before accepting executor registration. This prevents an
" +
+ "executor from connecting to the wrong driver in a port-reuse
scenario. " +
+ "External cluster managers that do not supply an application ID in the
" +
+ "identity-carrying RPC messages can set this to false for backward " +
+ "compatibility. The legacy bootstrap RPC always requires RPC " +
+ "authentication (spark.authenticate) to return credentials.")
+ .version("4.3.0")
Review Comment:
We use a UUID here instead of an appid, which makes things much more
convenient, we do not need to add new config:
https://github.com/apache/spark/blob/ec2ba8cc33f022e8d552d85d0a37a1b193b90d06/core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala#L66-L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
