pan3793 commented on PR #57762: URL: https://github.com/apache/spark/pull/57762#issuecomment-5180696333
Thanks for the review, @peter-toth! All findings are addressed in bdafe4d46b4: the gate is kept and changed to a coverage check per your suggestion, and the PR/JIRA titles are updated accordingly. On finding 2: right, `reorderJoinPredicates` already handles key order, so the gate never blocked reordered keys. The description is rewritten around the two real cases: duplicated join keys, and `allowKeysSubsetOfPartitionKeys=true` no longer needing `requireAllClusterKeysForCoPartition=false` alongside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
