Github user XuTingjun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6817#discussion_r32399782
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -553,12 +562,13 @@ private[spark] class ExecutorAllocationManager(
             }
     
             // If this is the last pending task, mark the scheduler queue as 
empty
    -        stageIdToTaskIndices.getOrElseUpdate(stageId, new 
mutable.HashSet[Int]) += taskIndex
    +        stageIdToTaskIndices.getOrElseUpdate(stageId, new 
mutable.HashSet[String]) += (taskIndex + "." + attemptId)
    --- End diff --
    
    if use taskIndex , when the new task (attempt id is not 0) is starting, the 
 stageIdToTaskIndices will not update, because the taskIndex is the same with 
the before failed task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to