cloud-fan commented on code in PR #57764:
URL: https://github.com/apache/spark/pull/57764#discussion_r3717493863
##########
dev/merge_spark_pr.py:
##########
@@ -615,6 +727,83 @@ def _do_cherry_pick(pr_num, merge_hash, pick_ref):
return pick_ref, pick_hash
+def branches_with_merge_footer(pr_num, branch_names):
Review Comment:
Please share the existing merge-status detector instead of adding a second
footer/branch scan here. `dev/pr_merge_status.py` already fetches official
branches, finds commits carrying this trailer, and maps them to containing
branches; this copy validates footer position but omits that refresh, while the
existing copy refreshes but lacks this validation, so the two committer tools
can disagree. Extract the footer parsing and commit-to-branch mapping into one
helper used by both scripts, with an explicit refresh policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
